Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: pigweed/pigweed
Branch: main
commit b041517545b70d1f73bbefa8f35576c330f36495
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:22:21 2024
bazel: Add missing dependencies
These deps were provided by some transitive dependency when using the
:light backend for pw_unit_test, but are revealed as missing when
building with the :googletest backend.
Bug: 352584464
Change-Id: Id17fa7ffd36ef88321cb03f0c93342956f16abb2
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222572
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
M pw_bluetooth/BUILD.bazel
M pw_bytes/BUILD.bazel
M pw_toolchain/BUILD.bazel
https://pigweed-review.git.corp.google.com/222572
Branch: main
commit b041517545b70d1f73bbefa8f35576c330f36495
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:22:21 2024
bazel: Add missing dependencies
These deps were provided by some transitive dependency when using the
:light backend for pw_unit_test, but are revealed as missing when
building with the :googletest backend.
Bug: 352584464
Change-Id: Id17fa7ffd36ef88321cb03f0c93342956f16abb2
Reviewed-on:
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
M pw_bluetooth/BUILD.bazel
M pw_bytes/BUILD.bazel
M pw_toolchain/BUILD.bazel
ap...@google.com <ap...@google.com> #3
Project: pigweed/pigweed
Branch: main
commit 41a0140c8ece3f4f64e70984499fcb45797c06d5
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:23:59 2024
third_party/googletest: Fix the docs
Bug: 352584464
Change-Id: I0310db525ae7428603e0bc80dc5be80f3fec72e4
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222573
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
M third_party/googletest/docs.rst
https://pigweed-review.git.corp.google.com/222573
Branch: main
commit 41a0140c8ece3f4f64e70984499fcb45797c06d5
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:23:59 2024
third_party/googletest: Fix the docs
Bug: 352584464
Change-Id: I0310db525ae7428603e0bc80dc5be80f3fec72e4
Reviewed-on:
Pigweed-Auto-Submit: Ted Pudlik <tpudlik@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
M third_party/googletest/docs.rst
ap...@google.com <ap...@google.com> #4
Project: pigweed/pigweed
Branch: main
commit 88dbbf23b2f7c6c51e48e488bbfd0592998b3f4d
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:40:04 2024
bazel: Run all tests with googletest backend in CI
Fixed: 352584464
Change-Id: Ie0f1ad38f3daaf6095a4512b53c15d60b7719627
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/222532
Reviewed-by: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
M .bazelrc
M pigweed.json
M pw_unit_test/BUILD.bazel
M targets/rp2040/transition.bzl
https://pigweed-review.git.corp.google.com/222532
Branch: main
commit 88dbbf23b2f7c6c51e48e488bbfd0592998b3f4d
Author: Ted Pudlik <tpudlik@google.com>
Date: Thu Jul 11 21:40:04 2024
bazel: Run all tests with googletest backend in CI
Fixed: 352584464
Change-Id: Ie0f1ad38f3daaf6095a4512b53c15d60b7719627
Reviewed-on:
Reviewed-by: Rob Mohr <mohrr@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Ted Pudlik <tpudlik@google.com>
M .bazelrc
M pigweed.json
M pw_unit_test/BUILD.bazel
M targets/rp2040/transition.bzl
Description
To ensure it works, we should run all upstream tests with the googletest backend.
The invocation is,
But this doesn't pass for me yet; fixes incoming!